Blocklist ipset logging

[Denna]

@Adamm,

I want to create a variable that could be referenced in multiple places, but its value easily changed in one. That would make it easier to change the maxelem value.​

Is this correct ?

blocklist_maxel=$(( 65536 + 7 ))
if [ "$(ipset -L BLOCKLIST | wc -l)" = "$(blocklist_maxel)" ]; then

 

[Adamm]

I think your better off defining 65543 and skipping the math entirely. The math involved will never change, so there is no reason to compute it every time the script runs. Math is more for situations where you are adding/subtracting two values that are non persistent and are potentially different every time the script runs.

Also in your example above you have the usage of $() wrong, $() means execute the code inside the brackets. To print a var you would use $var

blocklist_maxel="65543"
if [ "$(ipset -L BLOCKLIST | wc -l)" = "$blocklist_maxel" ]; then