Slight source problem

[Shonk]

You used 0 / 1
Just pointing it out..

<tr>
<th>Miniupnp: Enable secure mode (default: Yes)</th>
<td>
<input type="radio" name="upnp_secure" class="input" value="yes" <% nvram_match_x("", "upnp_secure", "yes", "checked"); %>><#checkbox_Yes#>
<input type="radio" name="upnp_secure" class="input" value="no" <% nvram_match_x("", "upnp_secure", "no", "checked"); %>><#checkbox_No#>
</td>
</tr>

 

[Nullity]

Who is "you"?

Can you be more clear about what the bug is?

 

[Shonk]

"You" Would be merlin ofc

/asuswrt-merlin/release/src/router/www/Tools_OtherSettings.asp

its ofc to do with the recent adding of upnp secure mode toggle
in the past i have used yes/no which worked fine

when i tried adding a port just now with 0/1 it failed

so i presume that it needs yes / no but ofc im not merlin so cant be 100%
he will know

 

[Shonk]

It may well be that i hadnt rebooted after applying the setting

/me checks

 

[RMerlin]

No, 1 and 0 are the proper values for that nvram setting. From rc/services.c:

nvram_get_int("upnp_secure") ? "yes" : "no",  // secure_mode (only forward to self)

 

[Shonk]

thanks merlin

im also getting this with the new miniupnp merge btw


Feb 16 21:35:07 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:35:07 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1
Feb 16 21:35:07 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:35:07 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1
Feb 16 21:35:07 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:35:07 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1
Feb 16 21:35:07 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:35:07 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1
Feb 16 21:51:55 miniupnpd[750]: upnp_event_recv: recv(): Connection reset by peer
Feb 16 21:51:56 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:51:56 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1

 

[RMerlin]

thanks merlin

im also getting this with the new miniupnp merge btw


Feb 16 21:35:07 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:35:07 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1
Feb 16 21:35:07 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:35:07 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1
Feb 16 21:35:07 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:35:07 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1
Feb 16 21:35:07 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:35:07 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1
Feb 16 21:51:55 miniupnpd[750]: upnp_event_recv: recv(): Connection reset by peer
Feb 16 21:51:56 miniupnpd[750]: addmasqueraderule() : chain UPNP-POSTROUTING not found
Feb 16 21:51:56 miniupnpd[750]: add_redirect_rule2(): addmasqueraderule returned -1

This is development code. I haven't even tested any of last night's changes yet.

 

[Shonk]

I know
just pointing it out
so you notice it slightly sooner

not in a rush for you to fix it
ofc

 

[Nullity]

I know
just pointing it out
so you notice it slightly sooner

not in a rush for you to fix it
ofc

You could fix it yourself (assuming there is a problem) and submit a pull request on github.