Incorrect firmware upgrade URL for AiMesh node

[pirx73]

In 386.3_2 and 386.4 URL to open AiMesh upgrade link from Administration/FirmwareUpgrade is generated incorrectly
URL for accessing main router is https://router_ip_addr:8443/ or DNS name respectively.

but URL for upgrading node is generated as
http://node_ip_addr/AiMesh_Node_FirmwareUpgrade.asp
instead which is not correct. It can be easily opened manually by correcting URL to the:
https://node_ip_addr:8443/AiMesh_Node_FirmwareUpgrade.asp
Not a big issue of course.
I checked page and URL seems to be auto-generated instead of static.

 

[bbunge]

Per chance do you have the Authentication Method set to Both?

 

[pirx73]

No, HTTPS only

 

[RMerlin]

Looking at the code, since 386.4's GPL merge Asus is generating the URL protocol based on the protocol used to access the router. So, it should be generating an https link if you are connected using an https link.

"aimesh_get_win_open_url" : function(_node_info, _page){
                var node_capability = httpApi.aimesh_get_node_capability(_node_info);
                var url = "http://" + _node_info.ip + "/" + _page;
                if(node_capability.local_access){
                        var header_info = httpApi.hookGet("get_header_info");
                        if(header_info.protocol == "https"){
                                url = "https://" + _node_info.ip + ":" + header_info.port + "/" + _page;
                        }
                }
                return url;
        },

If the node isn't reporting proper local_access capability, then this is outside of my control.

 

[pirx73]

Upgrade to 386.5 seemingly fixed it