spdMerlin spdMerlin - v4.x - speedtest and bandwidth monitoring

[aletaziar]

Added to my post while you were typing - where did you get 4.4.7? Have I missed something?

GitHub - AMTM-OSR/spdMerlin: spdMerlin is an internet speedtest and monitoring tool for AsusWRT Merlin with charts for daily, weekly and monthly summaries. It tracks download/upload bandwidth as well as latency, jitter and packet loss.

spdMerlin is an internet speedtest and monitoring tool for AsusWRT Merlin with charts for daily, weekly and monthly summaries. It tracks download/upload bandwidth as well as latency, jitter and pac...

github.com

Note that the install command has a mistake, and should not have `/install` in the path.

 

[Ripshod]

Back to your original question then.
What we're all seeing is just the fact that we have 'develop' versions installed that haven't yet been released. Effectively we're running stable betas.

 

[Martinski]

After updating several scripts to the new versions hosted by the AMTM-OSR/spdMerlin organization, I'm getting this in AMTM after an update check. Not really sure if this is an amtm issue or a problem with the scripts not changing their update url and MD5.
View attachment 65982

No official announcement has been made by the AMTM-OSR team that the "orphaned" add-on repositories are now "open for business" and integrated with AMTM.

Work is still in progress (it's not like flipping a simple switch), so until an official announcement is made of the next production releases, any add-on scripts that you download from the current AMTM-OSR repositories may not yet be fully modified, tested, validated, and integrated with AMTM support.

I'd suggest uninstalling whatever scripts you have now installed from the AMTM-OSR repos and reinstalling the previous versions from their original repositories.

 

[ExtremeFiretop]

After updating several scripts to the new versions hosted by the AMTM-OSR/spdMerlin organization, I'm getting this in AMTM after an update check. Not really sure if this is an amtm issue or a problem with the scripts not changing their update url and MD5.
View attachment 65982

Spdmerlin isn't even hosted by us yet in AMTM. It still points to JackYaz for now.

Added to my post while you were typing - where did you get 4.4.7? Have I missed something?

Nope.

What does this person mean by they updated "several scripts"

The only ones ready is FlexQoS and scMerlin. Anything else they are just giving themselves problems and should wait until we pump out the updates through AMTM.

 

[aletaziar]

What does this person mean by they updated "several scripts"

"This person" is right here, and used the install script from the repos. Perhaps they should be changed to private or the readmes edited to say that they're not production ready if that's the case, since the new org's readme encourages browsing the repo list to "Explore our Repositories to see which scripts are currently hosted under our stewardship." The various repos themselves only give installation commands and instructions to go to SNB for issues.

But I have done what you recommended and rolled back.

 

[ExtremeFiretop]

"This person" is right here, and used the install script from the repos.

So this confirms you installed custom scripts outside of AMTM support. This would naturally explain any issues you experienced.

Perhaps they should be changed to private or the readmes edited to say that they're not production ready if that's the case, since the new org's readme encourages browsing the repo list to "Explore our Repositories to see which scripts are currently hosted under our stewardship."

Yes; you can absolutely browse to see what repos have been accepted into the stewardship. That doesn't mean they are ready, we have nothing to hide with the work we are doing, or the repos accepted by the team. Putting them private would serve no additional purpose and we are accepting code contributions from people from outside the team so that would actually be a disadvantage.

The various repos themselves only give installation commands and instructions to go to SNB for issues.

We could add a note to mention that are not production ready, but they soon will be anyways.

But I have done what you recommended and rolled back.

I understand the desire to run the latest and greatest, but all I can say is trust the process and they will soon be available to update through the regular update process.

 

[aletaziar]

So this confirms you installed custom scripts outside of AMTM support. This would naturally explain any issues you experienced.

It isn't as though I was just browsing Github and decided to copy-paste every install command I saw. My thought process went like this:
- AMTM notifies me of new updates
- I check the repos and realize it's a new org
- I look through the org's readme and see it has reputable people behind it, and that it has repos for several scripts I already use
- The repos have versions above what I currently have
- None of the repos mention that they are pre-production

We could add a note to mention that are not production ready, but they soon will be anyways.

Even if they'll be production ready soon, I think you might as well put a note in the readme. It's such a superficial change and easy to remove when production happens.

I understand the desire to run the latest and greatest, but all I can say is trust the process and they will soon be available to update through the regular update process.

I guess I thought I was following the process, because the org and and the readmes just give the bash install commands. They don't mention "just wait for AMTM".

Anyway, thank you for continuing support for these scripts. Every router update I was concerned scripts would stop working.

 

[ExtremeFiretop]

It isn't as though I was just browsing Github and decided to copy-paste every install command I saw. My thought process went like this:
- AMTM notifies me of new updates
- I check the repos and realize it's a new org
- I look through the org's readme and see it has reputable people behind it, and that it has repos for several scripts I already use
- The repos have versions above what I currently have
- None of the repos mention that they are pre-production

I can see the confusion thinking this is the process when you list it out like that.
But you would need to be a somewhat "advanced" user to go through those motions you listed; and would depend too much on people following what's developing on SNBForums and reading posts.
We wouldn't expect regular users to transition that way it would be a pretty "rough" transition due to this.

Even if they'll be production ready soon, I think you might as well put a note in the readme. It's such a superficial change and easy to remove when production happens.

Feedback received. It's really up to @thelonelycoder as he makes the calls; and he decides when AMTM is "ready" to push out the new scripts.

I guess I thought I was following the process, because the org and and the readmes just give the bash install commands. They don't mention "just wait for AMTM".

No worries; as I mentioned above I can see how you might of thought this was the process.
But we have a much more elegant solution in mind involving the scripts regular update functions to make it as seamless as possible for the regular user.

Anyway, thank you for continuing support for these scripts. Every router update I was concerned scripts would stop working.

We thank you for the feedback and for being eager to test the latest releases.

 

[Tarek Yag]

As I have one of the slowest, worst internet connections on mother Earth, I've spotted a (rare) issue in spdMerlin, which should never appear to any modern internet connection user, hoping someone could fix it!

Obviously, it is caused by Speedtest auto converting measurement units in test result summaries. The following attachment summarizes the whole issue...

Dear team AMTM-OSR, @thelonelycoder, @ExtremeFiretop, @Martinski...
Sorry if I missed mentioning someone, I'm just trying to get your team's attention.

I've reported the bug quoted above in this post a while before the dream of reviving orphaned scripts came true. I would be very happy if you make a fix for this bug. And if not, I can still live with it peacefully

Note: The bug is still present in the latest version (4.4.9) and here's an updated screenshot of the bug for confirmation purposes. Additionally, here's the link of the latest speed test shown in the below screenshot.

Speedtest by Ookla - The Global Broadband Speed Test

Use Speedtest on all your devices with our free desktop and mobile apps.

www.speedtest.net

 

[ExtremeFiretop]

Dear team AMTM-OSR, @thelonelycoder, @ExtremeFiretop, @Martinski...
Sorry if I missed mentioning someone, I'm just trying to get your team's attention.

I've reported the bug quoted above in this post a while before the dream of reviving orphaned scripts came true. I would be very happy if you make a fix for this bug. And if not, I can still live with it peacefully

Note: The bug is still present in the latest version (4.4.9) and here's an updated screenshot of the bug for confirmation purposes. Additionally, here's the link of the latest speed test shown in the below screenshot.

Speedtest by Ookla - The Global Broadband Speed Test

Use Speedtest on all your devices with our free desktop and mobile apps.

www.speedtest.net

Report received. Will add it to my list of 4 things to investigate with Martinski hahaha no promises yet. We try to go based on importance and set a priority that way.

 

[Tarek Yag]

Report received. Will add it to my list of 4 things to investigate with Martinski hahaha no promises yet. We try to go based on importance and set a priority that way.

You all did a great job already on this script! I'm already enjoying all the new fixes and upgrades you've done. Best wishes anyhow.

 

[ExtremeFiretop]

You all did a great job already on this script! I'm already enjoying all the new fixes and upgrades you've done. Best wishes anyhow.

Can you confirm or deny if the actual results from a speedtest show correctly after a speedtest completes?

 

[Tarek Yag]

Can you confirm or deny if the actual results from a speedtest show correctly after a speedtest completes?

Absolutely! Here's the screenshot you just requested with the result URL too...

Speedtest by Ookla - The Global Broadband Speed Test

Use Speedtest on all your devices with our free desktop and mobile apps.

www.speedtest.net

EDIT: Replaced the screenshot to include the results table after the speed test too.

 

[Tarek Yag]

@ExtremeFiretop I replaced the screenshot in my previous post as it should be more useful for pinpointing the bug. I believe you've already seen the previous one; so I felt the need to make sure that you noticed the change. This is the reason behind this reply.

 

[ExtremeFiretop]

@Tarek Yag

Please run:

sh /jffs/scripts/spdmerlin develop

And test again, thanks!

 

[Tarek Yag]

And test again, thanks!

Hurray, this solved the bug perfectly, thank you!
Oops, but I didn't notice any time earlier that the bug is present for Download Data too!!
Here's your screenshot for the perfect fix! I just want you to make sure that the fix is applied to the downloaded data too. It's not usual for my internet to go below 1 Mbps!!!! But it's happening frequently nowadays. And it has happened today!
We're hoping that rebuilding Syria now -after finally getting our freedom- get us newly introduced Fiber Optic Internet to everyone!

 

[ExtremeFiretop]

Hurray, this solved the bug perfectly, thank you!
Oops, but I didn't notice any time earlier that the bug is present for Download Data too!!
Here's your screenshot for the perfect fix! I just want you to make sure that the fix is applied to the downloaded data too. It's not usual for my internet to go below 1 Mbps!!!! But it's happening frequently nowadays. And it has happened today!
We're hoping that rebuilding Syria now -after finally getting our freedom- get us newly introduced Fiber Optic Internet to everyone!

Yes the fix will be applied to both. Thanks for reporting!

 

[Tarek Yag]

Yes the fix will be applied to both. Thanks for reporting!

Thanks a lot!
I'll be monitoring for the next stable release to go back to the master branch.
Good luck everyone!

 

[ExtremeFiretop]

I'll be monitoring for the next stable release to go back to the master branch.

Martinski saw your message and dressed up the fix nice and pretty for you over my rough draft.

You shouldn't have to monitor for long... Keep your eyes open for a new release very very soon.