Menu
What's new
By:
Filters Better Search

Tools_Sysinfo page and correct WAN LAN show

  • SNBForums Code of Conduct

    SNBForums is a community for everyone, no matter what their level of experience.

    Please be tolerant and patient of others, especially newcomers. We are all here to share and learn!

    The rules are simple: Be patient, be nice, be helpful or be gone!

A

AndreyPopov

Senior Member
1. AC87 have 7 port for CPU - in Tools page logic only port 8 and 5 sutiable to CPU

2. others routers have different formulas of cpu/WAN/LANs


case MODEL_RTAC87U:
WAN L1 L2 L3 L4 CPU */
0, 5, 3, 2, 1, 7 };
case MODEL_RTN66U:
case MODEL_RTAC66U:
WAN L1 L2 L3 L4 CPU */
{ 0, 1, 2, 3, 4, 8 }; }
case MODEL_RTN16:
WAN L1 L2 L3 L4 CPU */
{ 0, 4, 3, 2, 1, 8 };
case MODEL_RTN15U:
WAN L1 L2 L3 L4 CPU */
{ 4, 3, 2, 1, 0, 8 };
case MODEL_RTN10U:
WAN L1 L2 L3 L4 CPU */
0, 4, 3, 2, 1, 5 };
case MODEL_RTAC56U:
case MODEL_RTN14UHP:
WAN L1 L2 L3 L4 CPU */
4, 0, 1, 2, 3, 5 };
case MODEL_RTAC68U:
case MODEL_RTAC3200:
case MODEL_RTN18U:
case MODEL_RTAC53U:
WAN L1 L2 L3 L4 CPU */
0, 1, 2, 3, 4, 5 };
case MODEL_RTN53:
case MODEL_RTN12:
case MODEL_RTN12B1:
case MODEL_RTN12C1:
case MODEL_RTN12D1:
case MODEL_RTN12VP:
case MODEL_RTN12HP:
case MODEL_RTN12HP_B1:
case MODEL_RTN10P:
case MODEL_RTN10D1:
case MODEL_RTN10PV2:
WAN L1 L2 L3 L4 CPU */
4, 3, 2, 1, 0, 5 };


RMerlin please help correct code in Tools page for correct show WAN and LANs

P.S. for ac87U now code already corrected.
 
Code: 
switch (based_modelid) :
{
		case RT-AC87U :
		{
			tmpPort = ???
			port = ???
			entry = ????
			code_ports = ???
		break;
		}

		case RT-AC66U :
		case RT-N66U :
		{
			tmpPort = ???
			port = ???
			entry = ????
			code_ports = ???
		break;
		}

		case RT-N16 :
		{
			tmpPort = ???
			port = ???
			entry = ????
			code_ports = ???
		break;
		}

		case RT-N15U :
		{
			tmpPort = ???
			port = ???
			entry = ????
			code_ports = ???
		break;
		}

		case RT-N10U :
		{
			tmpPort = ???
			port = ???
			entry = ????
			code_ports = ???
		break;
		}

		case RT-AC56U :
		case RT-N14UHP :
		{
			tmpPort = ???
			port = ???
			entry = ????
			code_ports = ???
		break;
		}

		case RT-AC68U :
		case RT-N18U :
		case RT-AC3200 :
		case RT-AC53U :
		{
			tmpPort = ???
			port = ???
			entry = ????
			code_ports = ???
		break;
		}

		case RT-N53 :
		case RT-N12 :
		case RT-N12A1 :
		case RT-N12B1 :
		case RT-N12C1 :
		case RT-N12D1 :
		case RT-N12HP :
		case RT-N12HP_V1 :
		case RT-N12VP :
		case RT-N10P :
		case RT-N10P_V2 :
		case RT-N10D1 :
		{
			tmpPort = ???
			port = ???
			entry = ????
			code_ports = ???
		break;
		}
}
 
may be code:
Code: 
			if (tmpPort == "8") {		// CPU Port
				continue;
			} else if (based_modelid == "RT-AC56U") {
				tmpPort++;		// Port starts at 0
				if (tmpPort == "5") tmpPort = 0;	// Last port is WAN
			} else if (based_modelid == "RT-AC87U") {
				if (tmpPort == "4")
					continue;	// This is the internal LAN port
				if (tmpPort == "5") {
					tmpPort = "4";	// This is the LAN 4 port from QTN
					devicename = "<unknown>";
				}
			}
			if (tmpPort == "0") {
				port = "WAN";
			} else {
				if ((based_modelid == "RT-N16") || (based_modelid == "RT-AC87U"))  tmpPort = 5 - tmpPort;
				port = "LAN "+tmpPort;
			}


with this
Code: 
switch (based_modelid) :
{
		case RT-AC87U :
		{
		  switch (tmpPort) :
			{
			  case 0 : port = "WAN";
			  case 1 : port = "LAN 4";
			  case 2 : port = "LAN 3";
			  case 3 : port = "LAN 2";
			  case 5 : port = "LAN 1";
			  case 4 :
			  case 6 :
			  case 7 :
			  case 8 :
			break;
			{
		break;
		}

		case RT-AC66U :
		case RT-N66U :
		case RT-AC68U :
		case RT-N18U :
		case RT-AC3200 :
		case RT-AC53U :
		{
		  switch (tmpPort) :
			{
			  case 0 : port = "WAN";
			  case 1 : port = "LAN 1";
			  case 2 : port = "LAN 2";
			  case 3 : port = "LAN 3";
			  case 4 : port = "LAN 4";
			  case 5 :
			  case 6 :
			  case 7 :
			  case 8 :
			break;
			{
		break;
		}

		case RT-N16 :
		case RT-N10U :
		{
		  switch (tmpPort) :
			{
			  case 0 : port = "WAN";
			  case 1 : port = "LAN 4";
			  case 2 : port = "LAN 3";
			  case 3 : port = "LAN 2";
			  case 4 : port = "LAN 1";
			  case 5 :
			  case 6 :
			  case 7 :
			  case 8 :
			break;
			{
		break;
		}

		case RT-N15U :
		case RT-N53 :
		case RT-N12 :
		case RT-N12A1 :
		case RT-N12B1 :
		case RT-N12C1 :
		case RT-N12D1 :
		case RT-N12HP :
		case RT-N12HP_V1 :
		case RT-N12VP :
		case RT-N10P :
		case RT-N10P_V2 :
		case RT-N10D1 :
		{
		  switch (tmpPort) :
			{
			  case 4 : port = "WAN";
			  case 0 : port = "LAN 4";
			  case 1 : port = "LAN 3";
			  case 2 : port = "LAN 2";
			  case 3 : port = "LAN 1";
			  case 5 :
			  case 6 :
			  case 7 :
			  case 8 :
			break;
			{
		break;
		}

		case RT-AC56U :
		case RT-N14UHP :
		{
		  switch (tmpPort) :
			{
			  case 4 : port = "WAN";
			  case 0 : port = "LAN 1";
			  case 1 : port = "LAN 2";
			  case 2 : port = "LAN 2";
			  case 3 : port = "LAN 4";
			  case 5 :
			  case 6 :
			  case 7 :
			  case 8 :
			break;
			{
		break;
		}
}
 
You're replacing 19 lines of code with 110 lines. With an interpreted language such as Javascript, this isn't very efficient.
 
RMerlin said:
You're replacing 19 lines of code with 110 lines. With an interpreted language such as Javascript, this isn't very efficient.
Click to expand...

more lines of code - I agree

but this code for 5 port models and more than 10 router models

your code have 8 if's to find what port wan or lan.
I think {switch ... case} may be faster in this situation, imho

I only ask your opinion.

thanks
 
like for me - work perfect:
Code: 
//Andrey begin
switch (based_modelid)
{
		case "RT-AC87U":
		{
		  switch (tmpPort) 
			{
			  case "0":
				port = "WAN";
				break;
			  case "1":
				port = "LAN 4";
				break;
			  case "2":
				port = "LAN 3";
				break;
			  case "3":
				port = "LAN 2";
				break;
			  case "5":
				port = "LAN 1";
				break;
			  default:
				port = "CPU";
			}
		break;
		}

		case "RT-AC66U":
		case "RT-N66U":
		case "RT-AC68U":
		case "RT-N18U":
		case "RT-AC3200":
		case "RT-AC53U":
		{
		  switch (tmpPort) 
			{
			  case "0":
				port = "WAN";
				break;
			  case "1":
				port = "LAN 1";
				break;
			  case "2":
				port = "LAN 2";
				break;
			  case "3":
				port = "LAN 3";
				break;
			  case "4":
				port = "LAN 4";
				break;
			  default:
				port = "CPU";
			}
		break;
		}

		case "RT-N16":
		case "RT-N10U":
		{
		  switch (tmpPort) 
			{
			  case "0":
				port = "WAN";
				break;
			  case "1":
				port = "LAN 4";
				break;
			  case "2":
				port = "LAN 3";
				break;
			  case "3":
				port = "LAN 2";
				break;
			  case "4":
				port = "LAN 1";
				break;
			  default:
				port = "CPU";
			}
		break;
		}

		case "RT-N15U":
		case "RT-N53":
		case "RT-N12":
		case "RT-N12A1":
		case "RT-N12B1":
		case "RT-N12C1":
		case "RT-N12D1":
		case "RT-N12HP":
		case "RT-N12HP_V1":
		case "RT-N12VP":
		case "RT-N10P":
		case "RT-N10P_V2":
		case "RT-N10D1":
		{
		  switch (tmpPort) 
			{
			  case "4":
				port = "WAN";
				break;
			  case "0":
				port = "LAN 4";
				break;
			  case "1":
				port = "LAN 3";
				break;
			  case "2":
				port = "LAN 2";
				break;
			  case "3":
				port = "LAN 1";
				break;
			  default:
				port = "CPU";
			}
		break;
		}

		case "RT-AC56U":
		case "RT-N14UHP":
		{
		  switch (tmpPort) 
			{
			  case "4":
				port = "WAN";
				break;
			  case "0":
				port = "LAN 1";
				break;
			  case "1":
				port = "LAN 2";
				break;
			  case "2":
				port = "LAN 3";
				break;
			  case "3":
				port = "LAN 4";
				break;
			  default:
				port = "CPU";
			}
		break;
		}
}
//Andrey end
			if ( port !== "CPU") {			
			entry = '<tr><td>' + port + '</td><td>' + (line[7] & 0xFFF) + '</td><td><span>' + state2 + '</span></td>';
			entry += '<td>'+ devicename +'</td></tr>';}
			else break;

tested on RT-N15U. now try on others RT-N10U and RT-N10P


P.S. and this code ready for future router models and switch ports models. ;)

P.S.P.S. I don't understand for what this code?
Code: 
			if (based_modelid == "RT-N16")
				code_ports = entry + code_ports;
			else
				code_ports += entry;
for what you add space (" ") for entry var if RT-N16?
 
Last edited:
You must log in or register to reply here.

Similar threads

F
ASUS RT-AC86U (merlin Current Version : 386.12_6): jffs2: Argh. No free space left for GC. Can you help me troubleshoot this please?
Replies
6
Views
352
fun4stuff
F
K
Double NAT?
Replies
1
Views
461
krl69
K
M
IPv6 and Router Advertisement adding route to delegated /56 via WAN interface
Replies
0
Views
205
MrC99
M
A
Policy-based port routing to bypass NordVPN client
Replies
10
Views
1K
Don->
D
E
[HACKED?] SSH not working all of a sudden (and strange log lines) - RTAC87U
Replies
17
Views
1K
elbubi
E
Similar threads
Thread starter Title Forum Replies Date
Dathuil Network Triage Tools in Merlin? Asuswrt-Merlin 6
U Syslog page causing browser to lock up when auto refresh turned on Asuswrt-Merlin 1
K The dreaded "HTTPS is a relatively more secured web access protocol. We strongly suggest to enter the ASUS router setting page via HTTPS protocol." Asuswrt-Merlin 16
A Time Scheduling page not loading properly Asuswrt-Merlin 0
C Where are the settings from GUI page USB FTP Share stored? Asuswrt-Merlin 9
A Primary router shows QIS_wizard page after IP conflict with secondary router in default mode Asuswrt-Merlin 2
B Is there an easy way to identify router on admin page? Asuswrt-Merlin 1
torstein Feature request asuswrt-merlin: Option to quickly disable radios from the front / status page Asuswrt-Merlin 11
V@no Don't show warning page when page was blocked? Asuswrt-Merlin 16
R AiMesh Topology shows an empty page on RT-AC86U Asuswrt-Merlin 4

Similar threads

Latest threads

Sign Up For SNBForums Daily Digest

Get an update of what's new every day delivered to your mailbox. Sign up here!

Members online

Total: 845 (members: 34, guests: 811)
Top