[Beta] AB-Solution 3.x

[elorimer]

Consider adding in the prompt for adding a domain to the whitelist:

Add domain like so: example.com or www.example.com
Add an explanatory comment like so:
www.example.com  #this comment explains why you are adding this site

Puzzling this out a little bit--I'm getting an error message adding a comment about a space in the url.

 

[Martin_D]

Updated to beta No problems at all

A B - S O L U T I O N        A D - B L O C K I N G

 AB-Solution 3.9                  by thelonelycoder
----------------------------------------------------
 RT-AC5300 (armv7l) fw-380.68 @ 10.82.235.1 IPv6
----------------------------------------------------
 263,309  blocked domains  9  hosts files in use
(logging off, no stats available)
----------------------------------------------------

beta Server  ab-solution.info  beta hosts [off]

 i   AB-Solution     [/tmp/mnt/AB-Solution]
 cu  check for updates
 un  updates notify  [off]
 bu  backup to email [off]

 a   ad-blocking     [on]
 l   logging         [off]
 rs  router stats    [off]

 ps  pixelserv-tls   [10.82.235.2]
     entware device  [/tmp/mnt/AB-Solution]

 b   blocking file   [shooter40sw] [Sun @ 2:00]
 u   update blocking file
 el  edit white or black list
 f   follow the logfile
 ac  update ads counter

 e   exit AB-Solution                   sm  sub menu
____________________________________________________

 Done  AB-Solution updated from 3.9.2 --> 3.9.3

 What do you want to do?

 

[thelonelycoder]

Consider adding in the prompt for adding a domain to the whitelist:

This is what I've done, your addition is only shown when a comment is added.
The screenshot is for the whitelist, the blacklist additionally shows the blocking IP in front of the domain.

Puzzling this out a little bit--I'm getting an error message adding a comment about a space in the url.

Not good and I can't replicate it. Can you post the exact domain and comment you add when that error shows?

 

[thelonelycoder]

BTW, exiting (e) while entering a domain or comment (see pic in above comment) will exit without adding anything at all. This is by design, the domain #comment is only added if the adding process is completed.

 

[thelonelycoder]

Puzzling this out a little bit--I'm getting an error message adding a comment about a space in the url.

I believe you add the comment at the time the domain is entered. This will not work as I check the domain validity at this time.
The comment can only be added in the next step. This is simpler for me to code.

How about like this, using the blacklist this time.
I have added "An explanatory comment can be added after this step" to the initial domain entry prompt.

 

[elorimer]

That is exactly the mistake I made, trying to add it all in one go.

I'm very good at this, you know: showing you how dumb one of your users can be.

 

[thelonelycoder]

That is exactly the mistake I made, trying to add it all in one go.

I'm very good at this, you know: showing you how dumb one of your users can be.

Oh, you are, that is one of the reasons you always were on the (private) beta threads. Keep up testing, and that is meant for all on this beta thread.

 

[thelonelycoder]

Now that one can add comments to white/blacklist entries would a "Edit comment" make sense?
Looks like a lot of coding to me for such a seldom used feature. The simplest way to do it now is to delete the domain and then re-add it with the new comment phrase. Also, there's the question if one should be able to add comments to existing comment-less entries.
All this is a lot of extra code in an already VERY large function.

 

[thelonelycoder]

EDIT: I fixed it myself. I just added another line with the info in it to be removed. Works like a charm.

As you've found, it's as simple as duplicating the line and change the text in
/please assign a default/
to a unique to that error/entry phrase in the syslog.

 

[yk101]

Thanks, @thelonelycoder!
Beta installed and running on RT-AC88U (armv7l) fw-382.1 without an incident.

 

[thelonelycoder]

functions.add and ab-solution.sh v3.9.3.1 are now available
Use cu to update.
See post No 1 for changes.

 

[elorimer]

Now that one can add comments to white/blacklist entries would a "Edit comment" make sense?

I think it is unnecessary. But I wonder whether it would be useful to comment out a domain by adding a #, or uncommenting it out by deleting it. I've got several domains in my whitelist that I can't figure out anymore why I put them there. I could edit the list manually, but half the point of ab-s is to trap idiot mistakes.

Also, I started to add a comment for something in my whitelist by adding it again (intending to delete the uncommented one later), and I see you trap for whether it is in the blocking list. If not, you don't add it to the list. I wonder, though, whether one should have the ability to force the addition, in case the blocking list when updated adds it back, or you change to a bigger list.

 

[thelonelycoder]

I think it is unnecessary. But I wonder whether it would be useful to comment out a domain by adding a #, or uncommenting it out by deleting it. I've got several domains in my whitelist that I can't figure out anymore why I put them there. I could edit the list manually, but half the point of ab-s is to trap idiot mistakes.

You'll have to reactivate the grey cells and ignore the IsIdiot=1 setting in your brain
I certainly wish I could...

The thing is, everything behind a "#" in a line in the blacklist (and the blocking file if I would not strip them) are ignored by Dnsmasq.
For the /jffs/shared-AB-whitelist I strip the comments out, and also to process the whitelist and when the blocking file is updated.
So far so good.

But then comes the "4. Sort and verify ...list.txt" in el. Here I strip out #comments lines between the domains.
In this example, the line "#some other comment" would be stripped out:

domain.com #comment
#some other comment
otherdomain.com #another comment

To add a feature to disable but not remove a domain from a list adds a lot of complexity.
Too much for now in my opinion.

Also, I started to add a comment for something in my whitelist by adding it again (intending to delete the uncommented one later), and I see you trap for whether it is in the blocking list. If not, you don't add it to the list. I wonder, though, whether one should have the ability to force the addition, in case the blocking list when updated adds it back, or you change to a bigger list.

I'll have to dig out the reason why we decided not to do it, we discussed this in an older beta thread already.

 

[thelonelycoder]

On the other hand @elorimer , a domain could be commented out with a distinctive string like #!:

domain.com #comment
#! thisdomain.com #comment for domain
otherdomain.com #another comment

This I could handle somehow.

 

[iManuB]

AB-Solution 3.9.3 Beta. Smooth!

    _   ___     ___      _      _   _
   /_\ | _ )___/ __| ___| |_  _| |_(_)___ _ _
  / _ \| _ \___\__ \/ _ \ | || |  _| / _ \ ' \
 /_/ \_\___/   |___/\___/_|\_,_|\__|_\___/_||_|

 Welcome
 This is AB-Solution 3.9 [3.9.3]

 looking for an installation
 found AB-Solution on /tmp/mnt/AB-Solution
 checking installation state
 updating ads counter
 reading services state
 starting UI

 A B - S O L U T I O N        A D - B L O C K I N G

 AB-Solution 3.9                  by thelonelycoder
----------------------------------------------------
 RT-AC3200 (armv7l) fw-380.68 @ 192.168.2.1
----------------------------------------------------
 441,141  blocked domains  6  hosts files in use
 7,328 t  2,402 w  538 n ads since Nov 15 00:18
----------------------------------------------------

beta Server  ab-solution.info  beta hosts [off]

 i   AB-Solution     [/tmp/mnt/AB-Solution]
 cu  check for updates
 un  updates notify  [off]
 bu  backup to email [off]

 a   ad-blocking     [on]
 l   logging         [on]
 rs  router stats    [off]

 ps  pixelserv-tls   [192.168.2.2]
     entware device  [/tmp/mnt/Entware]

 b   blocking file   [AdsBeGone!] [Mon @ 2:00]
 u   update blocking file
 el  edit white or black list

 f   follow the logfile
 ac  update ads counter

 e   exit AB-Solution                   sm  sub menu
____________________________________________________

 Done  updated ads counter: 7,328 total,
 2,402 this week, 538 new since last count

 What do you want to do?

 

[thelonelycoder]

AB-Solution 3.9.3 Beta. Smooth!

    _   ___     ___      _      _   _
   /_\ | _ )___/ __| ___| |_  _| |_(_)___ _ _
  / _ \| _ \___\__ \/ _ \ | || |  _| / _ \ ' \
 /_/ \_\___/   |___/\___/_|\_,_|\__|_\___/_||_|

 Welcome
 This is AB-Solution 3.9 [3.9.3]

 looking for an installation
 found AB-Solution on /tmp/mnt/AB-Solution
 checking installation state
 updating ads counter
 reading services state
 starting UI

 A B - S O L U T I O N        A D - B L O C K I N G

 AB-Solution 3.9                  by thelonelycoder
----------------------------------------------------
 RT-AC3200 (armv7l) fw-380.68 @ 192.168.2.1
----------------------------------------------------
 441,141  blocked domains  6  hosts files in use
 7,328 t  2,402 w  538 n ads since Nov 15 00:18
----------------------------------------------------

beta Server  ab-solution.info  beta hosts [off]

 i   AB-Solution     [/tmp/mnt/AB-Solution]
 cu  check for updates
 un  updates notify  [off]
 bu  backup to email [off]

 a   ad-blocking     [on]
 l   logging         [on]
 rs  router stats    [off]

 ps  pixelserv-tls   [192.168.2.2]
     entware device  [/tmp/mnt/Entware]

 b   blocking file   [AdsBeGone!] [Mon @ 2:00]
 u   update blocking file
 el  edit white or black list

 f   follow the logfile
 ac  update ads counter

 e   exit AB-Solution                   sm  sub menu
____________________________________________________

 Done  updated ads counter: 7,328 total,
 2,402 this week, 538 new since last count

 What do you want to do?

It should say "AB-Solution 3.9.3.1" if you updated recently.

 

[skeal]

It should say "AB-Solution 3.9.3.1" if you updated recently.

Yes it does 3.9.3.1

 

[iManuB]

Yep... I just did the upgrade now: 3.9.3.1

Thanks!

 

[thelonelycoder]

Seems like this beta version is ready for general release.
I'll do some more checks and if I hear nothing contrary here, release it as AB-Solution 3.9.3 later today.

 

[skeal]

No problems here!