[Beta] ModSyslogUI - seeking code reviewers and beta testers

[ColinTaylor]

@ColinTaylor I realize your question was just academic, but I believe the code is not dependent on Entware and a USB.

Unless I'm overlooking something in my code, the only portion of code that may be related is where I'm adding an alias for modsyslogui ==> that section checks if the /opt/bin directory exists (which I believe only exists if entware is installed which requires a USB) and if not, it then adds the alias to profile.add instead. The intent was to be able to add an alias whether entware was or wasn't installed.

Was there a dependency somewhere else in the code I'm overlooking?

I had assumed that Entware was a requirement because that's what you stated in post #1. To be honest I only glanced at your code, saw a few mentions of /opt and didn't look into it any further. Given that you already have the code in place to modify profile.add I'd be inclined to just use that and remove the code that links to /opt/bin. Keeps it consistent and simplifies things, but that's just my personal preference. Of course, there's the gotcha that after installation the user has to either log out and back in to the SSH session to pick up the alias, or use the full path name of the script.

 

[ColinTaylor]

But if it’s mistyped then surely it’s a null result, which is not what I got?
And what logical operators am I using that are incorrect. See error messages in the white boxes.
I’m not actually searching for anything I’m just testing, as requested, but even when I correct it I’m getting the messages, but not the correct filter?

If I’m inputting things incorrectly here I’m happy to be pointed in the right direction, especially if my trials work for others without the messages.

When "Boolean Include" is selected the input is very restricted in what it will accept. Where you're going wrong is thinking you can "stack" multiple logical operations (or enter nothing at all), you can't.

The only acceptable input is: xxxx <logical operation> yyyy

Not: xxxx <logical operation> yyyy <logical operation> zzzz

 

[jksmurf]

When "Boolean Include" is selected the input is very restricted in what it will accept. Where you're going wrong is thinking you can "stack" multiple logical operations (or enter nothing at all), you can't.

The only acceptable input is: xxxx <logical operation> yyyy

Not: xxxx <logical operation> yyyy <logical operation> zzzz

Oh I see;

I think I misread the 3 to 4 words as search terms, excluding the Boolean operands. But if it includes them it makes much more sense to be 3 in TOTAL (with AND or OR) or 4 in total, when AND NOT is used. So effectively you can only have two search terms.

Appreciate the explanation Colin.

 

[kstamand]

@ColinTaylor - thanks for providing the clarifications to jksmurf
@jksmurf - I noticed an script issue after my post this morning, where the UPDATE function wasn't working correctly. Unfortunately, it looks like you downloaded before I corrected things. Would you mind uninstalling and testing again and let me know if there are any other issues you come across or wording changes I might make to make the 3 vs 4 words limitations.

THANKS FOR THE TESTING AND FEEDBACK GUYS

 

[jksmurf]

@ColinTaylor - thanks for providing the clarifications to jksmurf
@jksmurf - I noticed an script issue after my post this morning, where the UPDATE function wasn't working correctly. Unfortunately, it looks like you downloaded before I corrected things. Would you mind uninstalling and testing again and let me know if there are any other issues you come across or wording changes I might make to make the 3 vs 4 words limitations.

THANKS FOR THE TESTING AND FEEDBACK GUYS

Goddag mann, økseskaft!.

Well I uninstalled it, downloaded it again as before, went to the gui, and it seems like Groundhog Day … sorry I must be doing something daft.

 

[dave14305]

sorry I must be doing something daft.

The syntax does not yet allow the period in wl1.1

 

[visortgw]

Goddag mann, økseskaft!.

Well I uninstalled it, downloaded it again as before, went to the gui, and it seems like Groundhog Day … sorry I must be doing something daft.View attachment 69829

Have you tried putting wl1.1 in double quotes?

 

[jksmurf]

Have you tried putting wl1.1 in double quotes?

[EDT] Words btw, suggests something you find in a dictionary. I’m not sure exactly what “hostapd” qualifies as, but I’m fairly certain I would not get away with it in scrabble.

Apparently they are called “fields, parameters, values, or sometimes tokens”…

 

[kstamand]

@jksmurf - apologies my friend. I didn't account for special characters (. or , or - , or ...) in one of the fields (or whatever we end up calling them - fields, or parameters, or values, or $#!??).

Besides those special character limitations, any other issues? Does the update function behave better (it should show no updates available currently)?

 

[jksmurf]

@jksmurf - apologies my friend. I didn't account for special characters (. or , or - , or ...) in one of the fields (or whatever we end up calling them - fields, or parameters, or values, or $#!??).

No problem at all, you asked for beta testers (clearly I don’t fall into the code checkers category) and you got the perfect checker.

You know what they say about never being able to make something completely foolproof, because as soon as you think you’ve done it, along comes a better fool (that's me). Glad to help, I like the concept as I originally said. I prefer this than the more powerful but not needed (for me) scribe.

So knowing the limitations, it works very well. btw, does it accept wildcards ? and * ? I didn’t test it, just thought I’d ask if it did.

Besides those special character limitations, any other issues? Does the update function behave better (it should show no updates available currently)?

Unfortunately, that still does not seem to work for me.