Possible bug in Main_TrafficMonitor_last24.asp

[sbsnb]

When viewing Main_TrafficMonitor_last24.asp toggling the scale dropdown to KB does not show KB.

The Total column still remains in MB units and the measurements have changed from 833.67 down and 32.91 up, to 801.07 down and 31.50 up.

 

[dave14305]

asuswrt-merlin.ng/release/src/router/www/tmmenu.js at 6f49271d261fff16d127ca55d78bc9df8d6f63e8 · RMerl/asuswrt-merlin.ng

Third party firmware for Asus routers (newer codebase) - RMerl/asuswrt-merlin.ng

github.com

Reference to the ScaleSize function.

 

[sbsnb]

Why does the number change?

It also changes from MB to GB or TB based on the dropdown.

 

[dave14305]

Why does the number change?

It also changes from MB to GB or TB based on the dropdown.

The ScaleSize function divides by 1024 instead of 1000.

 

[ColinTaylor]

Why does the number change?

It also changes from MB to GB or TB based on the dropdown.

It changes to the next higher units when the number exceeds 1000. (It doesn't go in the opposite direction)

 

[sbsnb]

It changes when you manually change the dropdown. Try it.

 

[sbsnb]

I don't understand the confusion. The total reads 833.67 MB when MB is selected in the dropdown. The total reads 801.07 MB when KB is select in the dropdown. I don't understand what that has to do with the ScaleSize() function.

 

[sbsnb]

Also, in the monthly and daily screens the totals are switched to the units in the dropdown.

 

[dave14305]

I don't understand the confusion. The total reads 833.67 MB when MB is selected in the dropdown. The total reads 801.07 MB when KB is select in the dropdown. I don't understand what that has to do with the ScaleSize() function.

For MB and higher, the bytes are divided by 1000 to get the desired units. When it’s KB, the bytes get processed by ScaleSize() and get divided by 1024 instead, so the final MB number will appear smaller than when MB is selected outright. It’s an inconsistency in the way unit conversions are handled in the firmware.

asuswrt-merlin.ng/release/src/router/www/tmcal.js at 6f49271d261fff16d127ca55d78bc9df8d6f63e8 · RMerl/asuswrt-merlin.ng

Third party firmware for Asus routers (newer codebase) - RMerl/asuswrt-merlin.ng

github.com

 

[sbsnb]

But it's not KB. The totals are labeled MB.

There is still the issue that switching the dropdown to MB, GB, or TB changes the totals to the corresponding unit. Only when switched to KB the units are changed to MB instead of KB. This is even inconsistent with the behavior on the Main_TrafficMonitor_daily.asp and Main_TrafficMonitor_monthly.asp.

 

[dave14305]

It’s fairly trivial to patch it and get consistent output. Maybe I’ll add it to my list of trivial pull requests on Github.

EDIT:

webui: Display Last 24 Hours Totals in KB when requested by dave14305 · Pull Request #813 · RMerl/asuswrt-merlin.ng

Keep units consistent by respecting user dropdown choice. Previous behavior reduced KBs to MB, GB or TB in order to keep the displayed sum less than 10000. Also use comma separators to keep larger ...

github.com