Updated the main router just fine, but the AiMesh node now has this log message repeating over and over. Zero search hits on google! Beta1 was just fine in this regard. I rebooted the mesh node, same behavior exists.
Any ideas? This is remote syslog via ui-scribe, AC86 x 2.
Code:
Apr 3 10:20:04 AC86U-OFFICE kernel: blog_request 1502: dev dpsta put_stats (null)
Apr 3 10:20:04 AC86U-OFFICE kernel: blog_request 1502: dev dpsta put_stats (null)
[...]
Googling around for blog_request, I found source!
Third party firmware for Asus routers (newer codebase) - RMerl/asuswrt-merlin.ng
github.com
Line 1485, case NETIF_PUT_STATS, which seems to involve transmitted and received packets, bytes, and multicast. dpsta (?) is the device name, and put_stats is null, which is suspicious.
Given that the patch from Asus 8 days ago involves changes to put_stats, I'd say that is the source of this log message.
2f7a878aad kernel: proper fix for wlan accumulating stats issue
Patch from upstream/Asus
github.com
In fact, the line that outputs the log message above was added in this patch! Given that dev_p->put_stats is null, instead of skipping the put_stats, it drops through and instead logs the above message. CONTINUOUSLY.
Code:
- if ( (dev_p->reg_state == NETREG_REGISTERED) && virt_addr_valid(dev_p->put_stats) )
- dev_p->put_stats( dev_p, bstats_p );
--------
+ if (dev_p->reg_state == NETREG_REGISTERED) {
+ unsigned long addr = (unsigned long)(dev_p->put_stats);
+ if (virt_addr_valid(dev_p->put_stats) || (addr >= MODULES_VADDR && addr < MODULES_END))
+ dev_p->put_stats( dev_p, bstats_p );
+ else
+ printk("%s %d: dev %s put_stats %p\n", __FUNCTION__, __LINE__, dev_p->name, dev_p->put_stats);
+ }
Most people likely won't see it, since how many have remote logging setup from an AiMesh node?
It looks harmless, maybe I'll setup a scribe/syslog-ng rule to just drop it. But thought I'd share the results of my detective work.
@RMerlin, any chance of adding "if (dev_p->put_stats != null)" prior to logging?
