Options missing from dnsmasq.conf

[LostFreq]

@RMerlin The following is from dnsmasq.conf.example:

# The following two options make you a better netizen, since they
# tell dnsmasq to filter out queries which the public DNS cannot
# answer, and which load the servers (especially the root servers)
# unnecessarily. If you have a dial-on-demand link they also stop
# these requests from bringing up the link unnecessarily.

# Never forward plain names (without a dot or domain part)
#domain-needed
# Never forward addresses in the non-routed address spaces.
#bogus-priv

I was wondering why the option bogus-priv was not showing up in my dnsmasq.conf, although I have Forward local domain queries to upstream DNS = No at the LAN - DHCP Server page.

It turns out that the option bogus-priv is only inserted if lan_dns_fwd_local is false AND lan_domain is not empty. This was added in commit e4ab66cf8dafe652edfad98a36d281b5a41c5fad (back in 2014).

I think the best thing would be to make a small change in release/src/router/rc/services.c so that these lines:

domain-needed
bogus-priv

are added if lan_dns_fwd_local is false, even if lan_domain is empty.

 

[ColinTaylor]

Good catch.

Although when lan_domain is not empty the domain-needed option would be redundant because there is a domain= option instead. But dnsmasq doesn't complain about both being present so that might making coding easier.

@john9527's firmware also exhibits the same behaviour.

 

[RMerlin]

Changed with this commit.