MerlinAU MerlinAU v1.4.6 - The Ultimate Firmware Auto-Updater (WEBUI + GNUTON SUPPORT!)

[kriukas]

I think just managed to re-create your issue. Seems to actually be within the _CIDR_IPaddrBlockContainsIPaddr_ function.
I think it might be possible the function is failing due to integer overflows with 32-bit arithmetic? Will try to adjust for 64-bit arithmetic and using awk.

If that is correct it would be a similar issue to our cron-job "time calculator" we originally had some problems with.
Will investigate a bit more in the weeds now.

I am sorry to disappoint you, but script doesn't even hit this fuction at all - litterary. It finishes at the line, which I have written Yesterday at 8:12 PM. - leaving it empty and then hitting warning text return 1 bellow finishing _CheckWebGUILoginAccessOK_() function.

I am glad to see your code improvemnt in above mentioned function towards the math approach, and in the same sorry, that I was unable to persuade you to look earlier in the code.

 

[ExtremeFiretop]

I am sorry to disappoint you, but script doesn't even hit this fuction at all - litterary. It finishes at the line, which I have written Yesterday at 8:12 PM. - leaving it empty and then hitting warning text return 1 bellow finishing _CheckWebGUILoginAccessOK_() function.

I am glad to see your code improvemnt in above mentioned function towards the math approach, and in the same sorry, that I was unable to persuade you to look earlier in the code.

Do you still have a device pending an update to 3006?

Can you retest the Changelog function while your testing. Thanks!

 

[kriukas]

Hi @kriukas

Please run this to test the latest version:

curl --retry 3 "https://raw.githubusercontent.com/ExtremeFiretop/MerlinAutoUpdate-Router/refs/heads/Fix-Web-Access-Restrictions/MerlinAU.sh" -o "/jffs/scripts/MerlinAU.sh" && chmod +x "/jffs/scripts/MerlinAU.sh"

Please report the results.

Hi dear @ExtremeFiretop,

I PM you the debug. As we both might be running in circles all this week long for no effect ;-)

 

[ExtremeFiretop]

Hi dear @ExtremeFiretop,

I PM you the debug. As we both might be running in circles all this week long for no effect ;-)

Yes that will be extremely helpful. Thank you.

 

[kriukas]

Do you still have a device pending an update to 3006?

Sure. Woun't let it slip half-backed.

Can you retest the Changelog function while your testing. Thanks!

Yes. But don't know what was intended in 1st place...? Care some doc link to read? Wouln't want to guess for myself.

At his very moment:

1. Changelog loads. But still old one.
2. "Approve change" is dissabled&cleared and doesn't seem to enter any other state - enable-ticked, enable-empty. (Install script update - also). All 4 buttons - enabled - working = pop-ups confirmation dialogs on click.
3. Changelog text is now keyboard-enabled for navigation with UP/DOWN arrows (thus slowly). Page Up/Down still moves whole page contents in the dimmed background.

 

[ExtremeFiretop]

Sure. Woun't let it slip half-backed.

Leave it pending the jump from 3004 to 3006 until I fully digest your debug you sent me, I'm currently at the office and will check into it a bit later.

3. Changelog text is now keyboard-enabled for navigation with UP/DOWN arrows (thus slowly). Page Up/Down still moves whole page contents in the dimmed background.

Perfect happy to hear this is working for you. I'll investigate the fact that it grabs the old Changelog next